Red fill the search stop icon

[madsrh]

Forwarded from https://bugs.launchpad.net/nautilus/+bug/1857869

It might be better if the search stop icon was red filled. Similar to a stop sign.

[madsrh]

WDYT @clobrano (related to #711 )

Would red and more red in hover, be better?

[clobrano]

I noticed the change, but I didn't react just because it was an upstream change. Indeed it was better red, at least on hover, but I think that reporting it upstream was the right move. Not so much he used a non-adwaita picture :D I will update upstream ticket :), and we can keep this open as reference, what do you think?

…

On Mon, 24 Feb 2020 at 09:15, MadsRH ***@***.***> wrote: WDYT @clobrano <https://github.com/clobrano> (related to #711 <#711> ) Would red and more red in hover, be better? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1980?email_source=notifications&email_token=AAWAAHRIC6SBXQK467A5V4LREN6YRA5CNFSM4KZ7GU7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMW5T7Y#issuecomment-590207487>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWAAHUEHZIQAU4SXA6LMI3REN6YRANCNFSM4KZ7GU7A> .

[madsrh]

Sounds good.

To me, it isn't obvious that the white shape is a button (or a stop sign)

[clobrano]

Indeed, and a red color on hover would be easier to understand

…

On Mon, 24 Feb 2020 at 09:32, MadsRH ***@***.***> wrote: Sounds good. To me, it isn't obvious that the white shape is a button (or a stop sign) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1980?email_source=notifications&email_token=AAWAAHU57MYCJPAN42FEGPTREOA3BA5CNFSM4KZ7GU7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMW7CDY#issuecomment-590213391>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAWAAHUTHAQWMCXDJM2BTWTREOA3BANCNFSM4KZ7GU7A> .

[clobrano]

green light for the change https://gitlab.gnome.org/GNOME/nautilus/issues/1375#note_722795

(actually the very first time a gnome dev says we can change the theme :D)