Cursor animation with outdated color. #2779

Initu-Castilhos · 2021-04-07T05:55:52Z

The color of the cursor animation is blue and does not match the color of the system. My suggestion is to change the color to Purple (Ubuntu standard) and green (Ubuntu-MATE).

Feichtmeier · 2021-04-07T10:34:49Z

We could try light aubergine, but I fear it might look too dark.
Or orange
@madsrh ?

madsrh · 2021-04-07T10:40:22Z

Sure, sounds very logical 👍

Feichtmeier · 2021-04-07T11:09:34Z

Edit: gtk spinner:

Test PR #2780
But it needs rendering, I fail to render this @Jupi007 could you render this into this test branch? 👼

Jupi007 · 2021-04-07T20:14:27Z

@Feichtmeier I rendered the cursors (Btw it looks very good), I also synced Gtk4. In fact you need to remove the .png files you want to render inside bitmaps and also use Inkscape 0.92 (I used my 20.04 VM).

I think the purple used on Gtk spinners should be lighten on dark theme.

madsrh · 2021-04-07T21:07:23Z

I think the purple used on Gtk spinners should be lighten on dark theme.

I think both light, dark and cursor could be a bit lighter/brighter. IMHO the purple feels a bit too strong compared to the current blue, but maybe that's just because we've had the blue for so long.

EDIT: I did not try the PR yet, so this is just looking at the screenshot 🤷‍♂️

Feichtmeier · 2021-04-07T21:43:48Z

Peek.2021-04-07.23-41.mp4

Peek.2021-04-07.23-43.mp4

Some footage

Jupi007 · 2021-04-08T09:06:50Z

You can also see the spinner inside the Gtk-widget-factory.

Feichtmeier · 2021-04-10T08:30:29Z

Let's postpone this to the next cycle. I'm still a bit torn

Benni3-1415 · 2021-06-02T17:21:28Z

The copy and the drag and drop copy cursors are in blue too.
Some suggestions:

Ubuntu: Primary (Orange)	Mate: Primary (green)	Success (green)

⭐ My favorite

Feichtmeier · 2021-06-02T18:58:09Z

I would go for orange too. And I think we should go also for orange for the spinners. Making thing overly complicated with all those many colors everythere does not really help

Benni3-1415 · 2021-06-03T08:46:03Z

IMO, we need a design guide that clarifies such questions, for example:

Accent colors

Primary (orange `#E95420`)

for things that the user actively does (focus, active) so the user can directly see, what he is doing.
I. e.: select a file, drag and drop, active form input

Secondary (aubergine `#924D8B`)

for passively things or those the user can't influence directly.
I. e.: slide-bar, checkbox, (wallpaper), wait for the system, other colored things

Active (transparent grey)

for things that the user has done or could do (hover, enabled) (same design conditions like in Gnome 40).
I. e.: hover on list item, active tab, active menu

Danger / error (red `#c7162b`)

for destructive (irreversible) actions.
I. e.: Delete Permanently (file), uninstall application, (close window)

Success (green `#109b26`)

for constructive or confirming actions.
Submit a form (i. e.: New Folder, Open File, send email)

Feichtmeier · 2021-06-03T08:58:18Z

I would generally agree with such static styling. But we've played around with this for years and this very burning orange only looks good when it is drawn in small elements such as stripes and little gems. The checkbox and switches look better with the light aubergine we currently use. I know it's inconsistent but it looks much better.
This issue is about removing the blue out of the palette which is good.

Isn't the plus cursor rather a success action?

madsrh · 2021-06-03T08:58:22Z

IMO, we need a design guide that clarifies such questions...

Do you have any thoughts here @elioqoshi ?

Benni3-1415 · 2021-06-03T09:06:21Z

What I wanted to say is that orange should only be used where something happens.

Isn't the plus cursor rather a success action?

I don't think so. You don't confirm something while dragging, you are doing something like you do something with an input form (and don't confirm it).

Feichtmeier · 2021-06-03T16:45:51Z

@Benni3-1415 sucking you back into this issue, I think even though the light aubergine looks good on a white disk, it looks bad in the dark gtk and shell themes as a spinner. That is the reason why we don't like the dark disk in the wait cursor, right?
That is why I would personally go for full orange for spinners, cursors and progress bars. But I know that others may disagree :)

Jupi007 · 2021-06-03T16:47:50Z

@Benni3-1415 sucking you back into this issue, I think even though the light aubergine looks good on a white disk, it looks bad in the dark gtk and shell themes as a spinner. That is the reason why we don't like the dark disk in the wait cursor, right?
That is why I would personally go for full orange for spinners, cursors and progress bars. But I know that others may disagree :)

I agree in all points, except for progress bars. I love our purple ones (I know this is not an argument 😅).

Benni3-1415 · 2021-06-03T17:01:58Z

Summary of #2804

Cursor spinner as add-on

If we see the spinner as an add-on to the cursor we could color it's border black and it is styled like the rest of the add-ons.
Next problem: Why are the add-on colors inverted?

👍 1

👍 1

Cursor spinner with dark bg

👎 4

🔼 also used in an older version of Suru
😕 3 | 👎 2

madsrh · 2021-06-03T17:18:26Z

If we see the spinner as an add-on to the cursor we could color it's border black and it is styled like the rest of the add-ons.
Next problem: Why are the add-on colors inverted?

@Benni3-1415 I understand what you are doing, but I really liked 😄 this idea?

Benni3-1415 · 2021-06-03T18:23:07Z

Is there really no way to convince Canonical to lighten up their light aubergine or to define our own very light aubergine?

Feichtmeier · 2021-06-03T18:28:43Z

When you lighten up it even further it becomes pink. Let's just go with orange. Orange is the main accent color of ubuntu, let's embrace it

Edit: there is one more alternative we didn't think about yet... we could change the cursor to white + light aubgerine spinner, but revert the gtk spinner back to upstreams "text color" spinner, in this case it would be just #f7f7f7 for the dark theme, and #3b3b3b for the lighttheme, because the purple spinners really do not work for the gtk theme #2779 (comment)

Benni3-1415 · 2021-06-04T14:02:00Z

To your idea @Feichtmeier, we could make the cursor white too:

If we see the spinner bg as the dark add-on border both spinner and copy cursor would look not boring and consisted.

Feichtmeier · 2021-06-04T14:04:37Z

Okay this looks cool 😃

Benni3-1415 · 2021-06-04T14:11:46Z

The pointer watch cursor looks fine, but maybe there is a bit too much color for the normal watch cursor, right?

Feichtmeier · 2021-06-04T16:38:47Z

Hm don't know would need to try it, I like the idea on the first look. We can then also change the gtk spinner to monochrome and be done with this topipc (and keep prple progress bars)

Feichtmeier · 2021-06-05T10:15:53Z

@Benni3-1415 could you include those changes in your pending cursor PR?

Benni3-1415 · 2021-06-05T10:33:48Z

I think it's a different topic, I create a new one ...

Benni3-1415 · 2021-06-05T10:45:09Z

Changes

Can someone else change the gtk theme, I don't know how to do it yet ... 🙂

Feichtmeier · 2021-06-05T11:02:17Z

~~working on it:~~ merged

Benni3-1415 · 2021-06-05T11:13:27Z

Do I have to build it, or is it enough to run the render-cursors.py script?

Feichtmeier · 2021-06-05T11:18:27Z

After changing the cursor SVGs you need to render the cursors, yes. but there is more to do I think. those X11 cursors?
@ubuntujaggers @Jupi007 pleas help Benni

Benni3-1415 · 2021-06-05T11:21:59Z

I find it very irritating that it makes a difference whether you build the repository or not, normally only the source code is in the repository.
I think I'll do a PR in the future to simplify the building process ...

Feichtmeier · 2021-06-05T11:37:10Z

If this is easier for you, you can just cretae one pull requests for both of your changes, we merge it, and our icon specialists render it when they come back, okay?

Benni3-1415 · 2021-06-05T12:02:35Z

Yes, good idea, I don't get the build correct.

The PR for this issue: #2885

Feichtmeier · 2021-06-05T12:11:19Z

Both of your PRs work on the same file - the chance is high that this result in a git conflict.
The best thing would be if you would include this change in your older PR

Benni3-1415 · 2021-06-05T12:46:57Z

Yes, I forgotten, merging the images would go terribly wrong!

Jupi007 · 2021-06-06T18:37:55Z

After changing the cursor SVGs you need to render the cursors, yes. but there is more to do I think. those X11 cursors?
@ubuntujaggers @Jupi007 pleas help Benni

Sorry for the long no-response, I was absent yesterday and today, and on top of that, I can't start Telegram anymore 😞

Well, I think you need to run w32-make.sh and x11-make.sh inside the icons/src/cursors folder to render cursors.

Feichtmeier · 2021-06-06T18:52:32Z

Np! Hope you are okay?

w32-make.sh does not work, it complains about the other script to be not existent even if it does. doubled checked the path 🤷 no idea

Jupi007 · 2021-06-06T19:00:08Z

Np! Hope you are okay?

Alright, thanks :)

w32-make.sh does not work, it complains about the other script to be not existent even if it does. doubled checked the path shrug no idea

Just tried w32-make.sh and that indeed do not work.
It says many and many times this:

Traceback (most recent call last):
  File "../anicursorgen.py", line 28, in <module>
    from PIL import Image
ImportError: No module named PIL

I checked and I have python3-pil installed.
@clobrano An Idea?

clobrano · 2021-06-06T19:44:18Z

I'll have a look

clobrano · 2021-06-06T19:53:07Z

well, basically it is based on python2, it needs rework 💪

Initu-Castilhos added the Area: icon theme label Apr 7, 2021

Feichtmeier added Area: gtk3 Area: gtk4 Status: Discussion labels Apr 7, 2021

swarajkothekar mentioned this issue Apr 24, 2021

hand cursor colour & wait cursor(spinner) colour #2804

Closed

Feichtmeier added Area: cursor theme and removed Area: icon theme Status: Discussion labels Jun 3, 2021

Benni3-1415 mentioned this issue Jun 5, 2021

Correct cursor colors #2885

Closed

Benni3-1415 mentioned this issue Jun 5, 2021

Simpler cursor shape / Correct cursor color #2868

Merged

Feichtmeier closed this as completed in #2868 Jun 5, 2021

Cursor animation with outdated color. #2779

Cursor animation with outdated color. #2779

Comments

Initu-Castilhos commented Apr 7, 2021

Feichtmeier commented Apr 7, 2021

madsrh commented Apr 7, 2021

Feichtmeier commented Apr 7, 2021 • edited Loading

Jupi007 commented Apr 7, 2021 • edited Loading

madsrh commented Apr 7, 2021 • edited Loading

Feichtmeier commented Apr 7, 2021

Jupi007 commented Apr 8, 2021

Feichtmeier commented Apr 10, 2021

Benni3-1415 commented Jun 2, 2021

Feichtmeier commented Jun 2, 2021

Benni3-1415 commented Jun 3, 2021 • edited Loading

Accent colors

Primary (orange #E95420)

Secondary (aubergine #924D8B)

Active (transparent grey)

Danger / error (red #c7162b)

Success (green #109b26)

Feichtmeier commented Jun 3, 2021

madsrh commented Jun 3, 2021 • edited Loading

Benni3-1415 commented Jun 3, 2021 • edited Loading

Feichtmeier commented Jun 3, 2021

Jupi007 commented Jun 3, 2021

Benni3-1415 commented Jun 3, 2021 • edited Loading

Summary of #2804

Cursor spinner as add-on

Cursor spinner with dark bg

madsrh commented Jun 3, 2021 • edited Loading

Benni3-1415 commented Jun 3, 2021

Feichtmeier commented Jun 3, 2021 • edited Loading

Benni3-1415 commented Jun 4, 2021 • edited Loading

Feichtmeier commented Jun 4, 2021

Benni3-1415 commented Jun 4, 2021

Feichtmeier commented Jun 4, 2021

Feichtmeier commented Jun 5, 2021

Benni3-1415 commented Jun 5, 2021

Benni3-1415 commented Jun 5, 2021

Changes

Feichtmeier commented Jun 5, 2021 • edited Loading

Benni3-1415 commented Jun 5, 2021

Feichtmeier commented Jun 5, 2021

Benni3-1415 commented Jun 5, 2021

Feichtmeier commented Jun 5, 2021

Benni3-1415 commented Jun 5, 2021 • edited Loading

Feichtmeier commented Jun 5, 2021

Benni3-1415 commented Jun 5, 2021

Jupi007 commented Jun 6, 2021

Feichtmeier commented Jun 6, 2021

Jupi007 commented Jun 6, 2021

clobrano commented Jun 6, 2021

clobrano commented Jun 6, 2021

Feichtmeier commented Apr 7, 2021 •

edited

Loading

Jupi007 commented Apr 7, 2021 •

edited

Loading

madsrh commented Apr 7, 2021 •

edited

Loading

Benni3-1415 commented Jun 3, 2021 •

edited

Loading

Primary (orange `#E95420`)

Secondary (aubergine `#924D8B`)

Danger / error (red `#c7162b`)

Success (green `#109b26`)

madsrh commented Jun 3, 2021 •

edited

Loading

Benni3-1415 commented Jun 3, 2021 •

edited

Loading

Benni3-1415 commented Jun 3, 2021 •

edited

Loading

madsrh commented Jun 3, 2021 •

edited

Loading

Feichtmeier commented Jun 3, 2021 •

edited

Loading

Benni3-1415 commented Jun 4, 2021 •

edited

Loading

Feichtmeier commented Jun 5, 2021 •

edited

Loading

Benni3-1415 commented Jun 5, 2021 •

edited

Loading