Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light theme light headerbar #1493

Merged
merged 14 commits into from Sep 9, 2019

Conversation

@Feichtmeier
Copy link
Contributor

commented Sep 9, 2019

Stop to invert the headerbar colors for the light theme.
Discussion can be found here #1477

Screenshot from 2019-09-05 07-19-10
Screenshot from 2019-09-06 05-12-38
Screenshot from 2019-09-06 05-14-56
Screenshot from 2019-09-06 05-16-07
Screenshot from 2019-09-06 05-16-42
Screenshot from 2019-09-06 05-18-35
Screenshot from 2019-09-06 05-20-52
Screenshot from 2019-09-06 05-21-54
Screenshot from 2019-09-06 05-22-02
Screenshot from 2019-09-06 05-28-54
Screenshot from 2019-09-06 05-44-32
Screenshot from 2019-09-06 05-45-01

While the dark yaru theme looks like this:
Screenshot from 2019-09-06 05-42-35
Screenshot from 2019-09-06 05-42-51
Screenshot from 2019-09-06 05-43-05
Screenshot from 2019-09-06 05-43-33
Screenshot from 2019-09-06 05-43-49

Eventually
Closes #1477

Feichtmeier added 9 commits Aug 31, 2019
Light hb in light theme
- to increase visibility of buttons in the light theme in the headerbar
- also produces less diff and decreases the risk of color problems with custom widgets in the headerbar

changes:
- remove color inversion from tweaks
- remove menu inversion for firefox
- darken light bg color by 1% to increase hover prelight effect in both gtk and shell themes
- add back the gradients from upstream to headerbar and buttons but decrease them
Use @madsrh headerbar bg colors and border
+ no purple for min/max buttons
Color changes
- old yaru gray/dark gray colors for hover/active elements because selected_bg_color is too strong in our color set
- re-vert darkening of the bg_color in both gtk and shell
Terminal additions
For the light theme a dark purple window does not work thus changing it to regular colors
Keeping the exact colors for the dark theme though
Change shell active gray
To match the hover gray, but darker
Feichtmeier added 3 commits Sep 9, 2019
Close button changes
- because firefox does not change the close buttons fg_color in the backdrop, the close button becomes invisible. To fix this we draw a subtle gray circle in the backdrop, thanks @clobrano
Adapt ubiquity to the new light theme
- until now overwrote the default look of ubiquity with the headerbar_bg_color but without the dark titlebar it looks weird, thus removing all custom code except dialogue margin and blue dots
@Feichtmeier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Ubiquity needed a change for this
image

Feichtmeier added 2 commits Sep 9, 2019
Refactor draw_circle
- make draw_circle only draw a circle
- move all :state logic into the style classes
- use old base hover and base active colors for min/max hovering
@Feichtmeier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Firefox needs the backdrop to keep a background for the close button... there is a white X on a almost white headerbar
image

After:
image

@Feichtmeier

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

Merging after +1 from @8none1 @madsrh and okay from @clobrano

@Feichtmeier Feichtmeier merged commit cb5caf3 into master Sep 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@Feichtmeier Feichtmeier added this to In progress in Yaru 19.10 via automation Sep 10, 2019

@Feichtmeier Feichtmeier moved this from In progress to Done in Yaru 19.10 Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1 participant
You can’t perform that action at this time.