Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust LO mimetype icons #3828

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Adjust LO mimetype icons #3828

merged 1 commit into from
Feb 28, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Feb 28, 2023

Before After
Mimetype Capture d’écran du 2023-02-28 15-39-32 Capture d’écran du 2023-02-28 15-34-29
App Capture d’écran du 2023-02-28 15-39-44 Capture d’écran du 2023-02-28 15-34-51

Writer and calc mimetype icons are not changed.
I did some little gradient adjustments on app icons.

Copy link
Member

@Muqtxdir Muqtxdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subtle changes looks good to me,thanks @Jupi007

@Jupi007
Copy link
Member Author

Jupi007 commented Feb 28, 2023

Thanks @Muqtxdir ❤️

I just wait for @madsrh opinion, then merging!

Copy link
Member

@madsrh madsrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @Jupi007 👍

@Jupi007 Jupi007 merged commit 3c3d85f into master Feb 28, 2023
@Jupi007 Jupi007 deleted the adjust-lo-mimetypes branch February 28, 2023 15:50
@rizmut
Copy link

rizmut commented Mar 28, 2023

Hi @Jupi007 this is great work. Thank you for passing on our LibreOffice design team's message about the need to distinguish between app icons and mimetype icons. I think there is still something that needs to be improved, namely the mimetype for protected documents. The files are in the directory sfx2/res/. All files start with 128x128 could be updated.

Here's how they looked like in the Start Center currently:

gambar

@Jupi007
Copy link
Member Author

Jupi007 commented Mar 28, 2023

Oh indeed, you're right thanks @rizmut!
I had forgotten these ones :)

@rizmut
Copy link

rizmut commented Mar 30, 2023

One more left: the "dummy" preview of Base file which is res/base_thumbnail_256.<png.svg>.

@Jupi007
Copy link
Member Author

Jupi007 commented Mar 30, 2023

@rizmut Thanks, I just updated it: ubuntu/libreoffice-style-yaru-fullcolor#314
I also checked all folders and I think I'm done now :)

bbjubjub2494 pushed a commit to bbjubjub2494/yaru-classic that referenced this pull request Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants