NODE_ENV setting is ignored by dockerStart.sh of data-portal

[taoliu]

compose-services/docker-compose.yml

Line 141 in 1ff3d52

- NODE_ENV=dev

The above code will set the NODE_ENV to "dev" in docker-compose.yml, however, this setting is ignored later on by data-portal. When "waitForContainers.sh" is called:

compose-services/docker-compose.yml

Line 135 in 1ff3d52

command: ["bash", "/var/www/data-portal/waitForContainers.sh"]

The script invokes "dockerStart.sh" in data-portal:

compose-services/scripts/waitForContainers.sh

Line 19 in 1ff3d52

bash ./dockerStart.sh

The dockerStart.sh will reset NODE_ENV as "production":

https://github.com/uc-cdis/data-portal/blob/c211f476f4ebacfe03b36bf471fb910e72aa81b4/dockerStart.sh#L8

export NODE_ENV=production

The consequence is that the NODE_ENV setting in compose-service is ignored.