Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cleversafe url #744

Merged
merged 18 commits into from
Mar 11, 2020
Merged

Feat/cleversafe url #744

merged 18 commits into from
Mar 11, 2020

Conversation

Avantol13
Copy link
Contributor

New Features

  • New config to specify an endpoint url for an s3 bucket (to support cleversafe)

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request introduces 1 alert when merging 81a1dea into f5a712b - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@lgtm-com
Copy link

lgtm-com bot commented Dec 18, 2019

This pull request fixes 15 alerts when merging 0c6a1d7 into f5a712b - view on LGTM.com

fixed alerts:

  • 10 for Missing call to __init__ during object initialization
  • 4 for Module is imported with 'import' and 'import from'
  • 1 for Flask app is run in debug mode

@coveralls
Copy link

coveralls commented Jan 6, 2020 •
edited

Pull Request Test Coverage Report for Build 8551

  • 16 of 17 (94.12%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 69.458%
Changes Missing Coverage Covered Lines Changed/Added Lines %
fence/blueprints/data/indexd.py 10 11 90.91%
Totals Coverage Status
Change from base Build 8512: 0.03%
Covered Lines: 5135
Relevant Lines: 7393
💛 - Coveralls

paulineribeyre
paulineribeyre reviewed Mar 6, 2020
View reviewed changes
fence/config-default.yaml Outdated
@@ -487,6 +487,8 @@ AWS_CREDENTIALS:
S3_BUCKETS:
bucket1:
cred: 'CRED1'
# optionally you can manually specify an s3-compliant endpoint for this bucket
endpoint_url: 'https://cleversafe.example.com/'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you still need a bucket region when using cleversafe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the code is using the region, so i'm not sure how it's working in prod... maybe they configured it with a fake region field. if not, it would fail trying to get the region from aws

fence/blueprints/data/indexd.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 10, 2020

This pull request introduces 1 alert when merging eacd20a into d3ce3bc - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@Avantol13 Avantol13 merged commit 97d74f1 into master Mar 11, 2020
@Avantol13 Avantol13 deleted the feat/cleversafe-url branch March 11, 2020 15:17
@emalinowski emalinowski restored the feat/cleversafe-url branch March 19, 2020 17:40
@paulineribeyre paulineribeyre deleted the feat/cleversafe-url branch October 22, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Avantol13 @coveralls @paulineribeyre