(PXP-4777) Feat/synapse userid (#739)

* feat(synapse): use userid as username * fix(synapse): use email from synapse
uc-cdis · Dec 4, 2019 · f5a712b · f5a712b
1 parent 9d96c91
commit f5a712b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/fence/blueprints/login/synapse.py b/fence/blueprints/login/synapse.py
@@ -26,7 +26,7 @@ def __init__(self):
 
     def post_login(self, user, token_result):
         user.id_from_idp = token_result["sub"]
-        user.email = token_result["email_verified"]
+        user.email = token_result["email"]
         user.display_name = "{given_name} {family_name}".format(**token_result)
         info = {}
         if user.additional_info is not None:

diff --git a/fence/resources/openid/synapse_oauth2.py b/fence/resources/openid/synapse_oauth2.py
@@ -15,10 +15,9 @@ class SynapseOauth2Client(Oauth2ClientBase):
 
     """
 
-    REQUIRED_CLAIMS = {"given_name", "family_name", "email", "email_verified"}
+    REQUIRED_CLAIMS = {"given_name", "family_name", "email", "email_verified", "userid"}
     OPTIONAL_CLAIMS = {
         # "company",
-        # "userid",
         # "orcid",
         # "is_certified",
         # "is_validated",
@@ -125,7 +124,7 @@ def get_user_id(self, code):
                         return dict(error="Required claim {} not found".format(claim))
                 else:
                     rv[claim] = value
-            rv["fence_username"] = rv["email"] + " (via Synapse)"
+            rv["fence_username"] = rv["userid"] + " (Synapse ID)"
             return rv
         except Exception as e:
             self.logger.exception("Can't get user info")