fix(sidecar): wrong error logic

uc-cdis · Oct 29, 2021 · 72e94b5 · 72e94b5
1 parent f812134
commit 72e94b5
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/sidecar/sidecar.go b/sidecar/sidecar.go
@@ -174,14 +174,16 @@ func (fm *S3FileManager) downloadInputFiles(taskS3Input []*TaskS3Input) (err err
 				s3Key, s3Bucket, err := getS3KeyAndBucket(taskInput.URL, taskInput.Path, fm)
 
 				if err != nil {
-					log.Infof("downloading; bucket - %v; key - %v", s3Bucket, s3Key)
-					_, err = downloader.Download(f, &s3.GetObjectInput{
-						Bucket: aws.String(s3Bucket),
-						Key:    aws.String(s3Key),
-					})
-					if err != nil {
-						log.Errorf("failed to download file with url %s and path %s with error %s: ", taskInput.URL, taskInput.Path, err)
-					}
+					log.Errorf("failed to get s3 key and bucket from %v; error - %v", taskInput.URL, err)
+				}
+
+				log.Infof("downloading; bucket - %v; key - %v", s3Bucket, s3Key)
+				_, err = downloader.Download(f, &s3.GetObjectInput{
+					Bucket: aws.String(s3Bucket),
+					Key:    aws.String(s3Key),
+				})
+				if err != nil {
+					log.Errorf("failed to download file with url %s and path %s with error %s: ", taskInput.URL, taskInput.Path, err)
 				}
 			}