This repository has been archived by the owner on Jul 14, 2022. It is now read-only.
Feat/pre genesis wf #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmhernan
reviewed
Oct 12, 2021
mariner/tool.go
Outdated
| path, err := filePath(v) | ||
| if err != nil { | ||
| tool.Task.infof("failed to extract path from file: %v", v) | ||
| continue |
There was a problem hiding this comment.
we should not continue here, instead we should return the error
kmhernan
reviewed
Oct 12, 2021
mariner/tool.go
Outdated
| path, err := filePath(f) | ||
| if err != nil { | ||
| tool.Task.infof("failed to extract path from file: %v", f) | ||
| continue |
There was a problem hiding this comment.
not continue, but return error
kmhernan
reviewed
Oct 12, 2021
mariner/tool.go
Outdated
| switch x := output.(type) { | ||
| case *File: | ||
| path := output.(*File).Path | ||
| tool.Task.infof("*File - Path: %v", path) |
There was a problem hiding this comment.
currently i dont handle this case, so either we handle it here or we just remove this and the []*File case below to be caught in default and throw the exception
kmhernan
reviewed
Oct 12, 2021
mariner/tool.go
Outdated
| continue | ||
| } | ||
| switch { | ||
| case strings.HasPrefix(path, userPrefix): |
There was a problem hiding this comment.
this series of case logic is repeated in many different areas here so perhaps should be turned into a function?
kmhernan
reviewed
Oct 12, 2021
| engine.IsInitWorkDir = "true" | ||
| tool.Task.infof("s3input paths: %v", tool.S3Input.Paths) | ||
| tool.Task.infof("initWorkDirFiles: %v", tool.initWorkDirFiles) | ||
| continue |
There was a problem hiding this comment.
I dislike how this function has to use the continue for this situation
UchicagoZchen138
force-pushed
the
feat/pre-genesis-wf
branch
2 times, most recently
from
b0ce0a3
to
b8a463c
Compare
UchicagoZchen138
force-pushed
the
feat/pre-genesis-wf
branch
from
b8a463c
to
3ba7f37
Compare
UchicagoZchen138
force-pushed
the
feat/pre-genesis-wf
branch
from
3ba7f37
to
f945835
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-8788 PXP-8788 PXP-8843
Feature
We have via this PR fixed a variety of bugs described in the tickets above. Also by fixing these bugs we are finally able to run the pre-genesis workflow.
Bug fix