Remove services and reduce TriggerBase to a library #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refresh_functions method replaces refresh_services.
The run method is irrelevant if TriggerBase is no longer a superclass for implementations.
Dissociate KafkaTrigger from TriggerBase. Instead, instantiate TriggerBase keep a reference in KafkaTrigger.
The TriggerBase class is no longer intended to be used as a superclass for trigger implementations. Rename it to Functions, instead. It provides supporting code for implementation to get information about functions.
Shorten the method refresh_functions to just refresh. The “_functions” is a bit redundant with the class being named functions.
_register_label is a property of Functions, not KafkaTrigger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove leftover references to services from the switch to functions. Also, reduce TriggerBase to use as a library object instead of a framework superclass for trigger implementations.
Closes #22