Ensure the crate user in the Docker image belongs to a group #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully allow easier access to shared volumes without having to change permissions on them.
RudolfCardinal
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create the Docker image, a
crateuser is created with the same ID as the current user ID on the host. This allows file permissions to be set correctly on mounted file systems shared between the container and the host, but only if they are owned by that user. If there is a shared file system that is group read/write but created by another user in the group then the current user will not be able to access it from Docker.This change creates a
crategroup in the Docker image and adds thecrateuser to that group. The ID of this group is specified by theCRATE_DOCKER_INSTALL_GROUP_IDenvironment variable. The installer sets this variable by looking at the groups the user belongs to (excluding os-generated groups). If there is only one group, the installer will use that. Otherwise it prompts the user to select a group ID from a list.In the future it might be useful to create multiple groups in the Docker image but let's leave it simple for now.
Includes some security fixes: requests, Tornado, urllib3