proofchain w/ builder pattern + minor convert updates #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/refactor-proofchain-to-builder
branch
from
6875d71
to
e4d1bfd
Compare
zeeshanlakhani
force-pushed
the
zl/refactor-proofchain-to-builder
branch
3 times, most recently
from
9f51bba
to
df35d9e
Compare
zeeshanlakhani
force-pushed
the
zl/refactor-proofchain-to-builder
branch
from
df35d9e
to
3c19e8a
Compare
|
@cdata just wanted to check-in on this one. |
zeeshanlakhani
force-pushed
the
zl/refactor-proofchain-to-builder
branch
from
3c19e8a
to
1104a41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personally, I felt that proofchain building felt more like a series of steps rather than one fn, b/c it always applied the parser (eventually
TODOresolver) and store. This does keep the parser and store attached to a chain, but as private fields, not publically accessible. It's a bit more verbose, but also validates the parser in a separate step, which I like.In Draft mode, associated w/ issue #39.
Includes: