Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple UCAN proofs & encode in base64url unpadded #24

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Allow multiple UCAN proofs & encode in base64url unpadded #24

merged 2 commits into from
Dec 3, 2021

Conversation

matheus23
Copy link
Member

See #22 and #23

Due to implementing multiple parent proofs, I the rootIssuer function doesn't make sense anymore - it's ambiguous.

@matheus23
Fix #23:
02a5aec 
Make everything base64url encoded instead of base64urlpad
@matheus23
Fix #22
375dbc2 
Make `proof` field an array of strings (encoded ucans)
instead of an optional string (one encoded ucan).
bgins
bgins approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Good changes to get in line with the specs.

@matheus23 matheus23 merged commit b80310a into main Dec 3, 2021
@matheus23 matheus23 deleted the matheus23/spec-fixes branch December 3, 2021 09:37
This was referenced Mar 19, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheus23 @bgins