-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement 0.8 spec #52
Conversation
bc60991
to
e8da99c
Compare
with: resourcePointer.prf(selector), | ||
can: ability | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we have functions for wnfs
and email
too? I realise they're not part of the spec, but could be helpful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm 🤔 For now I think we should keep them outside the public API 👍
I think this PR also partially implements #43? It's got some utility functions for creating
@matheus23 Do you think that after my 0.8 changes we need to adjust the |
459c213
to
0a37f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for @matheus23 to give this a look as well. |
0a37f49
to
b01b466
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! :) Thanks for reorganizing a bit & cleaning stuff up, too 🙏
@matheus23 Do you think that after my 0.8 changes we need to adjust the
CapabilitySemantics
parsing/delegating?
Yep! But we should do that in another PR. Let's ship incrementally 🚢
If you have any questions about how that hairy capabilities iterator works today, feel free to ping me in discord.
Also we'll likely want some tests for this stuff, but I think that makes most sense with the new capability semantics/parsing stuff from above 👆
This PR implements the 0.8.1 spec and thus closes #47.
The biggest change involves attenuations. I've taken the capability types, revised them to the new spec, taken them out of the
types.ts
module and split them up in several parts undersrc/capabilities/
, plus the top levelsrc/capabilities.ts
module. Each module in there has the types, utility functions, encoders/decoders, type checking functions, etc.Notes:
0.0.1
has been changed to0.3.0
tests/emailCapabilities.ts
totests/capabilities/email.ts
Todo/Questions: