Fix ESM build #92
Merged
Fix ESM build #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dholms
approved these changes
Oct 18, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ESM, other than in CJS, file endings are not automatically appended to import paths. The TypeScript compiler does not change this behavior; it emits the import statements exactly as written in the TypeScript source file. Imports without
.jsendings are only valid for either packages or named exports set in a package'spackage.json.This PR fixes the few spots where currently imports without file names are used. This makes the package compatible with Node.js in ESM mode.
I did not yet change all test imports, as they are not included in the published bundle anyways.
Fixes #91