Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use riscv-tools with gemmini - only install esp-tools for hwacha #1327

Merged
merged 8 commits into from
Feb 7, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Feb 5, 2023

This commit removes the dependency on esp-tools for gemmini's isa simulator. Gemmin's isa simulator is now packaged as a standalone dynamically loadable extension for upstream spike.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 changed the title De esp tools Use riscv-tools with gemmini - only install esp-tools for hwacha Feb 5, 2023
@jerryz123 jerryz123 marked this pull request as ready for review February 7, 2023 18:00
@jerryz123 jerryz123 merged commit 93414b5 into main Feb 7, 2023
@jerryz123 jerryz123 deleted the de-esp-tools branch February 7, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants