Makefile bug fixes #1336
Merged
Makefile bug fixes #1336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y the bin if bin given args
jerryz123
reviewed
Feb 9, 2023
| (set -o pipefail && $(NUMA_PREFIX) $(sim_debug) $(PERMISSIVE_ON) $(SIM_FLAGS) $(EXTRA_SIM_FLAGS) $(SEED_FLAG) $(VERBOSE_FLAGS) $(WAVEFORM_FLAG) $(PERMISSIVE_OFF) $(BINARY) </dev/null 2> >(spike-dasm > $(sim_out_name).out) | tee $(sim_out_name).log) | ||
|
|
||
| run-fast: run-asm-tests-fast run-bmark-tests-fast | ||
|
|
||
| ######################################################################################### | ||
| # helper rules to run simulator with fast loadmem via hex files | ||
| ######################################################################################### | ||
| $(binary_hex): $(output_dir) $(BINARY) | ||
| $(base_dir)/scripts/smartelf2hex.sh $(BINARY) > $(binary_hex) | ||
| $(binary_hex): $(firstword $(BINARY)) | $(output_dir) |
There was a problem hiding this comment.
Thanks for this, this has been bugging me for a while.
jerryz123
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firstwordto the hex-ification rule inrun-binary-hexto avoid bugs in the case whereBINARY='bin arg1 arg2'. Otherwise the hex-ficiation rule will be given the args as well.Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?