Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Verilog Prerequisites + Ignore mv stdout #1406

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Fix Verilog Prerequisites + Ignore mv stdout #1406

merged 4 commits into from
Mar 17, 2023

Conversation

abejgonzalez
Copy link
Contributor

@abejgonzalez abejgonzalez commented Mar 17, 2023

  • Fixes issue where if you updated a Verilog file, the SFC_LEVEL would be not set breaking the flow. Done by moving the VLOG_SOURCES as a prereq of SFC_LEVEL.
  • Adds new ibex.mk so that if a Ibex file is updated it would elaborate the SoC again (which would preprocess the Verilog sources)
  • Ignores mv stderr output (the error code is ignored anyways by using -)
  • xcelium support #1386 never passed CI. This fixes 2 errors with the PR, not init'ing the DramSim submodule and changing the int to size_t in cospike/spiketile.cc so that GCC can detect that the cfg_t constructor is valid.

Related PRs / Issues:
Requires review on ucb-bar/ibex-wrapper#5

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@abejgonzalez abejgonzalez merged commit c788fdc into main Mar 17, 2023
@abejgonzalez abejgonzalez deleted the small-fixes branch April 20, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants