Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements and fixes #1420

Merged
merged 27 commits into from
Apr 4, 2023
Merged

Various improvements and fixes #1420

merged 27 commits into from
Apr 4, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Mar 26, 2023

  • Support for TightlyCoupledMemory (TCM) in the Spike model, allowing for fast Linux boot with RTL simulation of the uncore with the SpikeUltraFastConfig
  • Add new "chosen" node to DTS, to request earlycon be with the sifive uart.
  • Add hello-world bare-metal program
  • Fix BOOM marchid
  • Fix icenet/rocc issues with default marshal kernel
  • Re-add password login

TODO:

  • Add note on docs explaining spike-TCM
  • Add RTL sim of linux boot with peripheral devices + drivers to CI

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a SpikeUltraFastConfig Linux boot test with RoCC instructions in CI just to ensure that things work properly.

@jerryz123
Copy link
Contributor Author

Unfortunately I wasn't able to speed-up SpikeUltraFast fast enough to get it to chew through user code fast enough for CI.

@abejgonzalez
Copy link
Contributor

Unfortunately I wasn't able to speed-up SpikeUltraFast fast enough to get it to chew through user code fast enough for CI.

Can we just add a simple test of something that just does a single user space RoCC instruction and finishes? Like build Gemmini Spike model and just do a Gemmini TLB flush.

@jerryz123
Copy link
Contributor Author

I'll try something out

@jerryz123
Copy link
Contributor Author

Even after 30 minutes, the SpikeUltraFast has not made its way through init. More work needs to be done to improve its performance before we can have full boot-poweroff CI on it, unfortunately.

@jerryz123
Copy link
Contributor Author

We need to merge this while rc-blocks is failing because the fix was squash-merged into rc-blocks. #1411 will fix this.

@jerryz123
Copy link
Contributor Author

@abejgonzalez I say we go for merge on this, #1411 is basically ready, and that will fix some of the commit-on-master checks

Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jerryz123 jerryz123 merged commit afd91d1 into main Apr 4, 2023
@jerryz123 jerryz123 deleted the fixes branch April 18, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants