Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump testchipip to standardize TL serdesser bundle params #1446

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented Apr 19, 2023

As long as people use the default STANDARD_TLBUNDLE_PARAMS, they shouldn't need to match up bundle params by hand.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@jerryz123 jerryz123 changed the title Bump testchipip to standardize tlserdes bundle params Bump testchipip to standardize TL serdesser bundle params Apr 19, 2023
Copy link
Contributor

@abejgonzalez abejgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongyihuang
Copy link

This is a good start, TL fields used for UCIe or other high bw busses should be much bigger to saturate bandwidth and mitigate latency. A bus like UCIe would require ~256/512 bit bus width from TL and bursts up to 2^(2^16) bytes. Standard fields here should be good for non-high BW off chip busses that uses regular IOs (lbwif), we can create bundles for other hbwif separately later.

@jerryz123 jerryz123 merged commit 6d8680b into main Apr 20, 2023
46 of 47 checks passed
@jerryz123 jerryz123 deleted the standard-serdes branch April 20, 2023 06:25
Copy link
Member

@T-K-233 T-K-233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants