Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uni-directional TLSerdesser #1476

Merged
merged 5 commits into from
May 19, 2023
Merged

Support uni-directional TLSerdesser #1476

merged 5 commits into from
May 19, 2023

Conversation

jerryz123
Copy link
Contributor

@jerryz123 jerryz123 commented May 13, 2023

This change fixes support for configs in which the TLSerdesser is unidirectional; that is, cases in which the chip acts as only the manager, and off chip acts as only the client.

This simplifies the memory map for all default designs as we no longer have to add a stub off-chip memory to provide the chip-client/harness-manager link.

Why not use the existing TLDesser/TLSerder, which already do this? Those IMO can be deleted as their implementations are now supported by the generalized TLSerdesser.

Since we support configs now where the serializer only acts as a client to the FBus, a bunch of WithSerialPBusMem fragments can be removed, as these were used to specify where the stub tilelink device sat.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Member

@T-K-233 T-K-233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It would be better if we name "serialManager*" as "serialTLManager*", but I think this is also fine.

@jerryz123
Copy link
Contributor Author

Looks good!

It would be better if we name "serialManager*" as "serialTLManager*", but I think this is also fine.

That a good idea. I'll make that change

@jerryz123 jerryz123 merged commit 7184848 into main May 19, 2023
48 checks passed
@jerryz123 jerryz123 deleted the serial-bump branch May 19, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants