Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex for similar module names that are uniquified #1640

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

abejgonzalez
Copy link
Contributor

When there is a module that is uniquified between the model and top, the regex in this file will improperly over-rename things. Ex: MemLoader is renamed to MemLoader_UNIQUE... however ReverseMemLoader would also be renamed. This PR fixes this issue by fixing the regex and adding more capture groups to properly capture spaces.

Fixes #1624

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

Copy link
Contributor

@joonho3020 joonho3020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abejgonzalez abejgonzalez reopened this Nov 2, 2023
@abejgonzalez abejgonzalez merged commit f8172d8 into main Nov 3, 2023
52 of 53 checks passed
@jerryz123 jerryz123 deleted the abejgonzalez-patch-3 branch January 21, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiSoC Configs should handle uniquification between harness and multiple ChipTops
2 participants