Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasHarnessInstantiators into MultiHarnessBinder #1674

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

abejgonzalez
Copy link
Contributor

In general, users should be able to generate arb. RTL in the harness and connect up any clock they want to it (for example to connect up a queue between IOs, debugging loggers, etc). This is supported with current HarnessBinders but not with MultiHarnessBinders specifically because the Multi* version doesn't have access to th: HasHarnessInstantiators. This adds this back to the MultiHarnessBinder when it was dropped on the PortAPI changes.

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

@abejgonzalez
Copy link
Contributor Author

Ready for review.

@abejgonzalez abejgonzalez merged commit a149085 into main Dec 4, 2023
52 checks passed
@abejgonzalez abejgonzalez deleted the th-in-mhb branch December 4, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants