Coordinate Top and Harness generation

[albert-magyar]

This avoids name conflicts between the design top and the test harness by coordinating the two FIRRTL compiler runs into one invocation of the main generator app. It also makes Verilog simulator generation somewhat faster.

Coordinated with ucb-bar/barstools#63

[abejgonzalez]

LGTM. Tested. We need to get barstools bumped. I also think we should at least another approval on the barstools PR.

[jwright6323]

I'm not sure I'm convinced that the harness blackboxes are handled correctly here, so I think we need to try this out on a design with a harness blackbox before merging. TOP_TARGETS and HARNESS_TARGETS are a nice touch.

[abejgonzalez]

Also ran this with the systolic project that initially caused the issue and this seemed to work.

[abejgonzalez]

Adding the "DO NOT MERGE" until the harness/top .f discussion is completed.

[abejgonzalez]

If I remember correctly... bumping FIRRTL cause a bunch of BOOM "firrtlation" issues where we would run out of memory. I don't know if this is a similar issue to the memoization problem that BOOM encountered in the past.

[colinschmidt]

If I remember correctly... bumping FIRRTL cause a bunch of BOOM "firrtlation" issues where we would run out of memory. I don't know if this is a similar issue to the memoization problem that BOOM encountered in the past.

Do you mean the firrtl issue I worked around here: ucb-bar/hwacha@ff4605f

[abejgonzalez]

Yup. That looks about right. To be honest, I wasn't familiar with the issue since Albert/David solved the issue before the BOOM team saw it.

[albert-magyar]

So this seems like just a "bump FIRRTL to head of master" issue. I can reproduce the OOM issues locally, but if I cherry-pick the FIRRTL commit that adds my .f features, things build fine.

I need to bisect this.

[abejgonzalez]

Can we merge dev into this to rerun CI with the new FIRRTL/barstool changes? (You probably also need to combine the barstools branches also)

[abejgonzalez]

This LGTM. I would prefer that the barstools PR is merged in first though.

[albert-magyar]

So the barstools PR is merged and this is passing all CI checks now.

[jwright6323]

LGTM