Remove references to ENABLE_YOSYS #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abejgonzalez
commented
Dec 13, 2023
| @@ -22,8 +22,6 @@ vlsi.inputs.placement_constraints: | |||
| bottom: 10 | |||
|
|
|||
| # Place SRAM memory instances | |||
| # SRAM paths and configurations are slightly different due to ENABLE_YOSYS_FLOW flag | |||
| # data cache | |||
| - path: "RocketTile/dcache/data/data_arrays_0_0/data_arrays_0_0_ext/mem_0_0" | |||
There was a problem hiding this comment.
Do these paths need to change?
abejgonzalez
commented
Dec 13, 2023
| @@ -54,8 +54,6 @@ vlsi.inputs.placement_constraints: | |||
| bottom: 10 | |||
|
|
|||
| # Place SRAM memory instances | |||
| # SRAM paths and configurations are slightly different due to ENABLE_YOSYS_FLOW flag | |||
| # data cache | |||
| - path: "ChipTop/system/tile_prci_domain/tile_reset_domain_tile/dcache/data/data_arrays_0_0/data_arrays_0_0_ext/mem_0_0" | |||
There was a problem hiding this comment.
Do these paths need to change?
abejgonzalez
commented
Dec 14, 2023
vlsi/tutorial.mk
Outdated
Comment on lines
42
to
43
| # Yosys compatibility for CIRCT-generated Verilog, at the expense of elaboration time. | ||
| ENABLE_YOSYS_FLOW = 1 |
There was a problem hiding this comment.
This needs to get reverted.
harrisonliew
approved these changes
Dec 15, 2023
|
Though I opened the PR, I approve of this (now that @nayiri-k fixed things). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that CIRCT 1.60.0 is released it should support disabling packed arrays for Yosys.
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
mainas the base branch?changelog:<topic>label?changelog:label?.conda-lock.ymlfile if you updated the conda requirements file?Please Backport?