-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scratchpad Documentation Fix #569
Conversation
I'm actually in favor of not documenting or including the DTIM scratchpad option. It doesn't seem to be something we would ever use. |
Is there a reason not to document it? |
It's not our job to document all of rocketchip, especially the features which we don't regularly use. |
It sounds like external users like both options described (2 external people looked at the documentation and asked questions / gave feedback on it). So I think its beneficial to keep it. |
To the actual content of the PR - there seems to be a mismatch between the text and the code example. You remove the memory port in the L1 code example, but in the text you say that you should do that for the mbus scratchpad case. |
No I do that for both cases? |
you're right, github diff got me again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related issue: #567
Type of change: bug fix
Impact: other
Release Notes
Fixes the docs.