Make vagrant provision run without root permission #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
lucasmoura
force-pushed
the
update_vagrant
branch
from
dd0c2b9
to
9919f71
Compare
|
jenkins test this please |
|
Test PASSed. |
lucasmoura
force-pushed
the
update_vagrant
branch
from
9919f71
to
e46a20e
Compare
|
jenkins test this please |
|
Test PASSed. |
|
jenkins test this please |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While developing with Vagrant, I just realized that the provision step is being executed with root permissions.
https://www.vagrantup.com/docs/provisioning/shell.html#privileged
Therefore, all files created during that step would belong to the root user. With that configuration, if an user using vagrant wants to run the tests, it will have to run as the root user, which is not necessary.
The above Figure shows the problem. This MR fixes that issue, by not allowing the provision step to be run with root permission.