Lh/request and lab ordered #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jSylvestre
reviewed
Oct 24, 2017
Anlab.Mvc/Services/IOrderService.cs
Outdated
|
|
||
| var calcualtedTests = new List<TestDetails>(); | ||
|
|
||
| foreach (var test in orderDetails.SelectedTests) | ||
| foreach (var test in tests) |
There was a problem hiding this comment.
@laholstege Is this correct?
There was a problem hiding this comment.
I'm thinking you want to keep the selectedTests, but add the LabOrder to the TestDetails model, then order by that in the return statement.
There was a problem hiding this comment.
@jSylvestre I want to keep LabOrder in the TestItemModel with RequestOrder. I ended up just removing dbTest because tests is already a list of TestItemModels that have the selected ids
srkirkland
approved these changes
Oct 25, 2017
There was a problem hiding this comment.
had the same question as @jSylvestre but if that part is correct then go for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #287