Removes redundant call to apiGetQuestionSet from scorescreen. #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clpetersonucf
requested changes
Mar 7, 2023
There was a problem hiding this comment.
This looks good and does the job as expected - the only thing I'd like to see, and only because we have tests for the widget_instances_get API call already already, is to add additional tests for non-authenticated users requesting specific instance information, and to test the $load_qset flag.
clpetersonucf
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
This does what's needed - looking back at the big picture, allowing score screens to be viewed without being logged in AND supporting custom score screens with access to the qset makes for a tricky situation, but definitely a bigger one than what this PR was designed to solve. We might revisit it in the future, but this will serve for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was raised within Guess The Phrase. I believe this may solve potential expiration issues, since the call to function question_set_get will sometimes cause the score screen to expire unnecessarily if the user is not authenticated. apiGetWidgetInstance has a built-in option to fetch the qset already, so I've made the score screen use that instead.