Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/1459 remove asset hash cache busting #1460

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Issue/1459 remove asset hash cache busting #1460

merged 4 commits into from
Mar 16, 2023

Conversation

clpetersonucf
Copy link
Member

Resolves #1459

Removes references to the dynamically compiled asset_hash.json, the hash processing code in alwaysload.php, and the process_assets.js file since it's no longer needed with the react branch.

@clpetersonucf clpetersonucf changed the base branch from master to issue/support-dashboard-in-react March 15, 2023 15:59
@clpetersonucf clpetersonucf marked this pull request as ready for review March 16, 2023 16:50
FrenjaminBanklin
FrenjaminBanklin approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@FrenjaminBanklin FrenjaminBanklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs locally.

Can't really 100% verify it myself, but assuming it also runs properly in CI/CD processes and builds a usable package for QA/Production use, willing to call it good.

@clpetersonucf clpetersonucf merged commit 8abc5cf into issue/support-dashboard-in-react Mar 16, 2023
@clpetersonucf clpetersonucf deleted the issue/1459-remove-asset-hash-cache-busting branch March 16, 2023 17:48
@clpetersonucf clpetersonucf mentioned this pull request Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrenjaminBanklin FrenjaminBanklin FrenjaminBanklin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[React branch] Remove & (eventually) replace asset cache busting
2 participants
@clpetersonucf @FrenjaminBanklin