added support for external feeds #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thetwam
reviewed
May 31, 2017
tests/fixtures/group.json
Outdated
| "url": "http://example.com/myblog.rss" | ||
| }, | ||
| "status_code": 200 | ||
| } |
There was a problem hiding this comment.
I made a mistake when merging in develop. Please add a comma after this bracket.
Thetwam
reviewed
May 31, 2017
canvasapi/course.py
Outdated
| @@ -945,6 +945,63 @@ def create_external_tool(self, name, privacy_level, consumer_key, shared_secret, | |||
|
|
|||
| return ExternalTool(self._requester, response_json) | |||
|
|
|||
|
|
|||
| def list_external_feeds(self): | |||
There was a problem hiding this comment.
Sorry, another mistake on my part. Please remove one of the blank lines above this function.
Thetwam
reviewed
May 31, 2017
Thetwam
added a commit
that referenced
this pull request
Jun 5, 2017
added support for external feeds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes issue #18
Added: