67 try ingesting branching routes as multilinestring objects #72
Conversation
…te into a MultiLineString
When run from the command line, the file extract_scheduled_gtfs.py should now iterate through the URLs for the static GTFS feeds for our three cities, transform the data to prepare it for storage, and write it to the PostGIS backend. Two small issues to consider before merging: 1) Many stop and route names go past the 30-character limit. When this happens, the entire upload for that stop or route is skipped. We may want to either consider extending that limit or truncating names for long stops (e.g. by taking the first 27 characters and adding "..." if the name is too long). 2) Some large bus systems seem to have multiple rows with the same stop_id, perhaps for different directions of travel or routes that pick up at the same stop. We should investigate further to see if this is fine or would cause issues linking to other data.
Delete unneeded single-LineString version of procedure to handroll geometrized routes (since we committed to MultiLineString approach). Clean up other comments and print messages here or there.
mbjackson-capp
requested review from
meganhmoore,
JPMartinezClaeys and
jimenasalinas
|
For future iterations (not urgent) we may want to separate ingestion from extraction to allow for tests to work |
|
Can we get a screenshot of tests passing if its too much to migrate tests to the |
| ) | ||
| print( | ||
| f'Observation created: {row["city"]}, {row["stop_id"]}, ' | ||
| f'{row["stop_name"]}, Point({row["stop_lat"]},{row["stop_lon"]})' | ||
| f", mode {obs.mode}" | ||
| ) | ||
| print(obs) | ||
| try: |
There was a problem hiding this comment.
Good for this stage, but let's keep in mind for later to get more specific try-excepts
| return BUS | ||
|
|
||
|
|
||
| def handroll_multiline_routes(city: str, feed) -> gpd.GeoDataFrame: |
There was a problem hiding this comment.
I get this is fine for now, but I don't find the name of the function particularly clear on what should do.
|
Looks good to me! I made some updates with my latest PR that migrated your test file to the That being said, most of those tests are currently being skipped and outdated imports were commented out (https://github.com/uchicago-capp-30320/RouteRangers/blob/main/app/route_rangers_api/tests.py#L11-L16) so if you want to make an issue to go back and update those tests, delete the ones that are no longer needed, etc. please do! doesn't have to be high priority though |
mbjackson-capp
deleted the
67-try-ingesting-branching-routes-as-multilinestring-objects
branch
Ingesting branching routes as MultiLineString objects was successful. Ingestion script for TransitStop and TransitRoute is in good enough condition to merge into main.