Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetworkSpawner Catalogues #41

Open
sebjf opened this issue Dec 4, 2023 · 0 comments · May be fixed by #45
Open

NetworkSpawner Catalogues #41

sebjf opened this issue Dec 4, 2023 · 0 comments · May be fixed by #45
Assignees
Labels
enhancement New feature or request

Comments

@sebjf
Copy link
Member

sebjf commented Dec 4, 2023

This is the counterpart to #40, which is the less minor thing that keeps coming up.

The NetworkSpawner Catalogue is included with the Samples. I.e. its maintained upstream. However users need to add their own Prefabs to it.
The NetworkSpawner should be modified so users don't have to change any Sample files to make their project work.

One way to do this is to make the NetworkSpawner take a List of Catalogues. Users can create a Catalogue for their project, and add it to the Spawner, where that association will be saved with the Scene.

The downside of this is that they will need the same configuration between all Scenes for the indexing to work.
So, the referencing also needs to be changed so that the identity is taken from property of the Prefab that is project-wide (where possible).

Additionally, when spawning at the Room level, there should be an API that supports co-routines or callbacks, so users can reference the instance after it is created in one function.

@sebjf sebjf self-assigned this Dec 4, 2023
@sebjf sebjf linked a pull request Jan 10, 2024 that will close this issue
@sebjf sebjf added the enhancement New feature or request label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant