Fix bug with continuous legends #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaneng
reviewed
May 19, 2023
R/legend.grob.R
Outdated
Comment on lines
149
to
151
| boundaries <- seq(0, max.value, length.out = n.labels + 1); | ||
|
|
||
| sapply( |
There was a problem hiding this comment.
Indent off here at least on github maybe just spaces/tabs mixed?
There was a problem hiding this comment.
Seems like it! Should be fixed now.
There was a problem hiding this comment.
Whitespace is still not good. There are a bunch of tabs before sapply
There was a problem hiding this comment.
Seems to be fixed now. (Disregard the refactor - indentation should be the same before vs. after.)
I actually found out about this issue because of a failing example from
|
stefaneng
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In new versions of R (> R v4.3.0), lattice does not allow
labelsto be specified in adraw.colorkeywithout corresponding values forat. This change fixes BPG's call todraw.colorkeywithinlegend.grob, placing labels equidistant along the range of continuous values.Checklist
This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
This PR does NOT contain molecular files, compressed files, output files such as images (e.g.
.png, .jpeg),.pdf,.RData,.xlsx,.doc,.ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.I have read the code review guidelines and the code review best practice on GitHub check-list.
I have set up or verified the
mainbranch protection rule following the github standards before opening this pull request.The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have added the major changes included in this pull request to the
NEWSunder the next release version or unreleased, and updated the date. I have also updated the version number inDESCRIPTIONaccording to semantic versioning rules.Both
R CMD buildandR CMD checkrun successfully.