Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text ability for create.histogram #78

Merged
merged 2 commits into from
May 23, 2023
Merged

Conversation

stefaneng
Copy link
Contributor

Description

Implement add.text capabilities for create.histogram. Identical implementation to create.barplot

Closes #21

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • I have set up or verified the main branch protection rule following the github standards before opening this pull request.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

Example

suppressPackageStartupMessages(library(BoutrosLab.plotting.general));
set.seed(10);
x <- rnorm(100);
create.histogram(
    x = x,
    add.text = TRUE,
    text.x = -2,
    text.y = 20,
    text.labels = 'Text'
    );

Created on 2023-01-09 with reprex v2.0.2

@stefaneng stefaneng requested review from dan-knight and a team as code owners January 9, 2023 22:44
Copy link
Contributor

@tyamaguchi-ucla tyamaguchi-ucla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @dan-knight for final approval.

Copy link

@lydiayliu lydiayliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @stefaneng

@stefaneng stefaneng assigned dan-knight and unassigned dan-knight Apr 14, 2023
@dan-knight dan-knight merged commit d40e427 into main May 23, 2023
@dan-knight dan-knight deleted the stefaneng-histogram-text-21 branch May 23, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create.histogram does not have the option to add additional text
4 participants