Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve intervals when needed #73

Merged
merged 8 commits into from
May 29, 2024
Merged

Conversation

yashpatel6
Copy link
Collaborator

@yashpatel6 yashpatel6 commented May 29, 2024

Description

Closes #65

Adding intervals resolution for places where the index file needs to be found if present

Testing Results

  • NFTest
    • log: /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/yashpatel-resolve-intervals/log-nftest-20240529T192354Z.log
    • cases: default set
  • Additional Case 1
    • sample: Targeted panel
    • log: /hot/software/pipeline/pipeline-recalibrate-BAM/Nextflow/development/unreleased/yashpatel-resolve-intervals/run.log

Checklist

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline using NFTest, or I have justified why I did not need to run NFTest above.

Copy link

Bleep bloop, I am a robot.

Alas, some of the Nextflow configuration tests failed!

test/configtest-F16.json

@ ["manifest","version"]
- "1.0.0"
+ "1.0.1"
@ ["params","log_output_dir"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z"
@ ["params","output_dir_base"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/GATK-4.2.4.1"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/GATK-4.2.4.1"
@ ["report","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/report.html"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/report.html"
@ ["timeline","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/timeline.html"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/timeline.html"
@ ["trace","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/trace.txt"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/trace.txt"

test/configtest-F32.json

@ ["manifest","version"]
- "1.0.0"
+ "1.0.1"
@ ["params","log_output_dir"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z"
@ ["params","output_dir_base"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/GATK-4.2.4.1"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/GATK-4.2.4.1"
@ ["report","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/report.html"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/report.html"
@ ["timeline","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/timeline.html"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/timeline.html"
@ ["trace","file"]
- "/tmp/outputs/recalibrate-BAM-1.0.0/TWGSAMIN000001/log-recalibrate-BAM-1.0.0-19970704T165655Z/nextflow-log/trace.txt"
+ "/tmp/outputs/recalibrate-BAM-1.0.1/TWGSAMIN000001/log-recalibrate-BAM-1.0.1-19970704T165655Z/nextflow-log/trace.txt"

If the above changes are surprising, stop and determine what happened.

If the above changes are expected, there are two ways to fix this:

  1. Automatically: Post a comment starting with "/fix-tests" (without the quotes) and I will update the tests for you (you must review my work afterwards).
  2. Manually: Follow these steps on Confluence.

@nwiltsie
Copy link
Member

@yashpatel6 Wait! Let me fix the tests correctly with this one!

Copy link
Member

@nwiltsie nwiltsie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yashpatel6 yashpatel6 merged commit 3ee8f38 into main May 29, 2024
7 checks passed
@yashpatel6 yashpatel6 deleted the yashpatel-resolve-intervals branch May 29, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update interval handling
2 participants