Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clang 3.9 build to Travis matrix #753

Merged
merged 2 commits into from
Apr 27, 2016

Conversation

julienmalik
Copy link
Collaborator

No description provided.

@julienmalik
Copy link
Collaborator Author

Updates #752

@julienmalik
Copy link
Collaborator Author

With the latest fix, the build now runs OK in travis with clang-3.9.

Only some tests are failing :
https://travis-ci.org/uclouvain/openjpeg/jobs/125578218#L3794-L3801
while they don't fail with gcc or clang-3.4

@julienmalik
Copy link
Collaborator Author

MemorySanitizer has improved in clang between between 3.4 and 3.9. My final aim was to set up a msan build in travis to track down introduction of bad code (in addition to catching a bit more warnings). With clang-3.9 it is possible to get the stack trace easily.

Also I found it has some advantage over valgrind : quicker in general (3x, and additionnal 2x with symbolizing the output), and execution of tests can be stopped as soon as a defect is detected.

@mayeut
Copy link
Collaborator

mayeut commented Apr 25, 2016

I've got the same tests failing on my setup. Can you add the correct exception list for clang-3.9 so that the PR shows successful under Travis CI ?

@julienmalik
Copy link
Collaborator Author

@mayeut Now it passes with the known failures exceptions added. I rebased and squashed everything.

Not sure though if keeping both release and debug builds is relevant/useful.

@mayeut
Copy link
Collaborator

mayeut commented Apr 27, 2016

@julienmalik, Thanks.

The matrix is already quite big and, as you said, keeping both release & debug configurations might not be relevant/useful.

I think you could remove either one of them (preferably remove the debug build to get faster tests) or replace the existing ASan build with clang-3.9

@mayeut mayeut merged commit 5947e10 into uclouvain:master Apr 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants