Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverity 113065 (CWE-484) #824

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Conversation

mayeut
Copy link
Collaborator

@mayeut mayeut commented Sep 7, 2016

@detonin,

I'm almost sure the fall through is intentional otherwise nothing would work but, just to be sure, can you confirm ?
The added comment will tell coverity not to report an issue & the code will be clearer for everyone.

@detonin
Copy link
Contributor

detonin commented Sep 8, 2016

@mayeut yes this is intentional and can be merged.
What I actually wonder is if we need to keep t1_generate_luts where it currently is. It has been used to generate a static file (t1_luts.h) but there is no need to compile it each time we compile OpenJPEG: I think we should keep t1_luts.h and move t1_generate_luts in the tools folder for instance.

@mayeut
Copy link
Collaborator Author

mayeut commented Sep 8, 2016

@detonin, agreed for the file location. I'll let you create an issue for this as a reminder.

@mayeut mayeut merged commit b21a831 into uclouvain:master Sep 8, 2016
@mayeut mayeut deleted the fix-coverity branch September 8, 2016 20:15
@detonin
Copy link
Contributor

detonin commented Sep 12, 2016

@mayeut #831

malaterre pushed a commit that referenced this pull request Sep 13, 2016
@detonin detonin added the bug label Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants