Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 526: HashNameVocab SHA3 Support #527

Merged
merged 5 commits into from
Mar 28, 2023
Merged

Issue 526: HashNameVocab SHA3 Support #527

merged 5 commits into from
Mar 28, 2023

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Mar 16, 2023 •
edited by ajnelson-nist
Loading

This Pull Request resolves all requirements of Issue #526

Coordination

  • Pull Request is against correct branch
  • Pull Request is in, or reverted to, Draft status before Solutions Approval vote has passed
  • CI passes in UCO feature branch against develop
  • CI passes in UCO current unstable branch (0571345)
  • CI passes in CASE current unstable branch tracking UCO's unstable as submodule (1c35bd9)
  • Impact on SHACL validation reviewed for CASE-Examples
  • Impact on SHACL validation remediated for CASE-Examples (N/A)
  • Impact on SHACL validation reviewed for casework.github.io
  • Impact on SHACL validation remediated for casework.github.io (N/A)
  • Milestone linked
  • Solutions Approval vote logged on corresponding Issue (once logged, can be taken out of Draft PR status)

kchason and others added 2 commits March 16, 2023 12:44
@kchason
Add SHA3 vocabulary options
c65bafe
@ajnelson-nist
Clarify synchronization test output
4ee0ddd 
PR 527 triggered `test_semi_open_vocabulary_owl_shacl_alignment`, and
left unhelpful-looking messages in the log output.  This patch changes
the behavior to name the shape to check.

References:
* ucoProject#527

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this pull request Mar 16, 2023
Merged
10 tasks
@ajnelson-nist
Merge branch 'BugFix-clarify_synchronization_test_output' into 526-Ha…
b4531df 
…shNameVocab-SHA3

Note: This state is still expected to fail CI.
@ajnelson-nist
Synchronize types:Hash shape with vocabulary:HashNameVocab
41592ff 
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject#527

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
ab03753 
References:
* ucoProject#527

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist marked this pull request as draft March 16, 2023 21:35
@ajnelson-nist ajnelson-nist added this to the UCO 1.2.0 milestone Mar 16, 2023
@ajnelson-nist ajnelson-nist linked an issue Mar 16, 2023 that may be closed by this pull request
HashNameVocab should have SHA-3 Hash Functions #526
Closed
10 tasks
@ajnelson-nist ajnelson-nist mentioned this pull request Mar 16, 2023
Closed
10 tasks
@ajnelson-nist ajnelson-nist changed the title HashNameVocab SHA3 Support Issue 526: HashNameVocab SHA3 Support Mar 16, 2023
@ajnelson-nist ajnelson-nist marked this pull request as ready for review March 27, 2023 15:54
@ajnelson-nist
Copy link
Contributor

This is ready to merge. I had a bit of a heavy implementation update over @kchason 's initial patch, so I'd prefer to not merge myself.

plbt5
plbt5 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@plbt5 plbt5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a proper and simple way to determine SHA3 support, and identify representation failures in hashes.

@plbt5 plbt5 merged commit 0cc0305 into ucoProject:develop Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plbt5 plbt5 plbt5 approved these changes

Assignees
No one assigned
Labels
Change Proposal
Projects
None yet
Milestone
UCO 1.2.0
Development

Successfully merging this pull request may close these issues.

HashNameVocab should have SHA-3 Hash Functions
3 participants
@kchason @ajnelson-nist @plbt5