Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Varosi appveyor #1361

Closed
wants to merge 63 commits into from
Closed

Varosi appveyor #1361

wants to merge 63 commits into from

Conversation

ranjitjhala
Copy link
Member

A new PR applying @varosi 's appveyor changes to the latest develop.

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Oct 11, 2018

Hi @varosi -- looks like rebasing against the latest develop helps with circle. However, the appveyor builds are failing for two reasons:

  1. the long file names?
  2. somehow HsColour is not getting built due to some tab/spaces issue?

For 2 is it possible to disable that warning in the appveyor script?
For 1 we could potentially split those giant "log" files into some separate repo? Would that help?

EDIT: actually looks like your renaming of the files was not applied in the PR. Hmm. Maybe I can just do it manually...

Actually looks like it was applied in the PR but somehow the appveyor build is still trying to checkout the files:

error: unable to create file tests/logs/regrtest_results_goto_Fri_Sep_21_17:19:54_2012: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Mon_Feb__4_08:25:21_2013: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Mon_Oct_22_15:45:04_2012: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Mon_Oct_22_20:52:56_2012: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Sat_Feb_23_18:38:19_2013: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Sun_Jan_13_17:11:09_2013: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Sun_Jul_13_22:12:12_2014_post_errormsg_parseparens: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Sun_Oct_28_17:24:34_2012: Invalid argument
error: unable to create file tests/logs/regrtest_results_goto_Wed_Nov_20_15:28:50_2013-master: Invalid argument
error: unable to create file tests/logs/regrtest_results_nikiL_Fri_Mar_29_12:56:37_2013: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Fri_Jul_29_17:38:55_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Mon_Dec__5_03:32:39_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Sun_Sep_11_15:52:57_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Sun_Sep_11_19:38:55_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Sun_Sep_11_20:12:06_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Thu_Dec_22_02:51:46_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Tue_Jul_19_10:07:18_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_03:11:45_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_03:14:29_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_16:45:26_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_18:09:31_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_18:42:19_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_19:13:26_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Dec_21_19:14:10_2011: Invalid argument
error: unable to create file tests/logs/regrtest_results_ubuntu_Wed_Sep__7_14:45:19_2011: Invalid argument
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.

Any idea why?

Thanks!

@varosi
Copy link
Contributor

varosi commented Oct 11, 2018

Great about CircleCI! Problems with "Invalid agrument" are because of colons (":") in file names. In my branch (commit a992e59) I have renamed them to not have colons. It's strange that they are still present.

@varosi
Copy link
Contributor

varosi commented Oct 11, 2018

It's interesting that problem in hscolor is in it, not in liquidhaskell:

C:\tmp\stack2544\hscolour-1.24.4\Language\Haskell\HsColour.hs:37:19: warning: [-Wtabs]
280 Tab character found here, and in two further locations.
281 Please use spaces instead.
282 |
283 37 | -> String -- ^ Title for output.
284 | ^^^^^^
285 ignoring (possibly broken) abi-depends field for packages
286

Something in the new LTS I think. We could try with some other version of it.

@ranjitjhala
Copy link
Member Author

I disabled the tabs warning to make progress, but its getting stuck on something else, c.f.

https://ci.appveyor.com/project/ranjitjhala/liquidhaskell/builds/19440719

Do you know if it is possible to "log onto" the VM to inspect the log to see what the problem is?

@varosi
Copy link
Contributor

varosi commented Oct 17, 2018

I tried this: https://www.appveyor.com/docs/how-to/rdp-to-build-worker/
It works well, but only from Windows machine doing remote desktop.
You could cherry pick latest commit (33fe462ed5446e805f78e09ff4a44b3302c9b642) on my branch to enable RDP.
One problem is that the VM is live only 60min. On my tests it is even less.

@varosi
Copy link
Contributor

varosi commented Oct 17, 2018

It's strange... your branch is building fine on my Windows machine. May be it's something with the VM. Could you restart the build?

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Oct 17, 2018 via email

@varosi
Copy link
Contributor

varosi commented Oct 18, 2018

@ranjitjhala, could you restart the CI? or push something to your branch so it try to rebuild? I don't have rights to push to that branch on your repo.

@varosi
Copy link
Contributor

varosi commented Oct 23, 2018

haskell/cabal#5465

@varosi
Copy link
Contributor

varosi commented Oct 23, 2018

I have reproduced the error at my AppVeyor instance, so I'll try to fight it by myself - https://ci.appveyor.com/project/varosi/liquidhaskell/builds/19737975

@varosi
Copy link
Contributor

varosi commented Dec 16, 2018

I hit a bad error on AppVeyor using GHC 8.4 - commercialhaskell/stack#4441 This problem is fixed in GHC 8.6. liquid-fixpoint module is building with 8.6 just fine. But building liquidhaskell itself rises lot of errors which are not trivial for me to fix without deep knowledge on LiquidHaskell.

@ranjitjhala, do you have plans to make it build with 8.6?

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Dec 17, 2018 via email

@nikivazou
Copy link
Member

Yes! 8.6 is the stable current release!

@varosi
Copy link
Contributor

varosi commented Dec 17, 2018

It's stable as @nikivazou said, all tests on all libraries in current Stackage nightly are passing on three OSes. And it's close to release of LTS. As I know they don't do additional tests except those that are made on nightly bases automatically. GHC compiler is updated twice after the official release and soon we'll have it in LTS 13.

@varosi
Copy link
Contributor

varosi commented Dec 24, 2018

Happy LTS! Now with GHC 8.6.3
https://www.stackage.org/lts-13.0

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Dec 29, 2018 via email

@varosi
Copy link
Contributor

varosi commented Dec 29, 2018 via email

@varosi
Copy link
Contributor

varosi commented Dec 29, 2018 via email

@nikivazou nikivazou closed this Mar 26, 2019
@nikivazou
Copy link
Member

So, hopefully windows build is fixed with our upgrade!

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Mar 26, 2019 via email

@nikivazou
Copy link
Member

In the comments @varosi said there is a fix in ghc-8.6

@varosi
Copy link
Contributor

varosi commented Mar 26, 2019

Yes, I have tested with GHC-8.6 before.
So now LiquidHaskell use GHC-8.6! Yay! I'll test it

@ranjitjhala
Copy link
Member Author

ranjitjhala commented Mar 26, 2019 via email

@varosi
Copy link
Contributor

varosi commented Apr 1, 2019

#1442

@nikivazou nikivazou deleted the varosi-appveyor branch June 10, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants