Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

Update http links to https #305

Merged
merged 1 commit into from
May 4, 2017
Merged

Update http links to https #305

merged 1 commit into from
May 4, 2017

Conversation

VivianChu
Copy link
Member

Fixes #304 ; refs #304

Update http links to https link to fix mixed protocol errors.

@ucsdlib/developers - please review

mcritchlow
mcritchlow previously approved these changes May 4, 2017
Copy link
Member

@mcritchlow mcritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far as I can tell, this covers the remaining http links. Thanks @VivianChu !

I think we need to have a very thorough testing plan for this, more so than a usual release.

@gamontoya and @ucsdlib/domm could we ask you all to really go try out several things when we get a release candidate into the test environment? We can work on making a list of specific areas to hit, in addition to general clicking around the site.

@gamontoya
Copy link

@mcritchlow @ucsdlib/domm Yes, I'll be happy to help, but we need to know exactly what we're testing for.

@mcritchlow
Copy link
Member

@gamontoya will do 👍 we'll make a list on the release ticket

@VivianChu - only thing I noticed after the fact. What about changing the instances of libraries to library in the URLs? I think those are mostly in the css/js files.

@mcritchlow mcritchlow dismissed their stale review May 4, 2017 20:48

will request changes for libraries -> library

Copy link
Member

@mcritchlow mcritchlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks great.

Just need to change any instance of libraries to library. This seems mostly localized to JS/CSS files.

Reverse https change

Change instance of libraries to library
@VivianChu
Copy link
Member Author

@mcritchlow - All instances of libraries have been changed to library.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 66.54% when pulling f81a006 on feature/https into c28ef03 on develop.

@lsitu
Copy link
Member

lsitu commented May 4, 2017

👍

1 similar comment
@hweng
Copy link
Contributor

hweng commented May 4, 2017

👍

@mcritchlow mcritchlow merged commit 475a6a3 into develop May 4, 2017
@mcritchlow mcritchlow deleted the feature/https branch May 4, 2017 23:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants