-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far as I can tell, this covers the remaining http links. Thanks @VivianChu !
I think we need to have a very thorough testing plan for this, more so than a usual release.
@gamontoya and @ucsdlib/domm could we ask you all to really go try out several things when we get a release candidate into the test environment? We can work on making a list of specific areas to hit, in addition to general clicking around the site.
@mcritchlow @ucsdlib/domm Yes, I'll be happy to help, but we need to know exactly what we're testing for. |
@gamontoya will do 👍 we'll make a list on the release ticket @VivianChu - only thing I noticed after the fact. What about changing the instances of |
will request changes for libraries -> library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great.
Just need to change any instance of libraries
to library
. This seems mostly localized to JS/CSS files.
Reverse https change Change instance of libraries to library
@mcritchlow - All instances of libraries have been changed to library. |
👍 |
1 similar comment
👍 |
Fixes #304 ; refs #304
Update http links to https link to fix mixed protocol errors.
@ucsdlib/developers - please review