This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
fields: add more ordered names #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract out ordered roles to a YAML file to make it easier to adjust in the future - Add a few additional tests for new roles in the ordered listing - Add a few role examples to damsProvenanceCollection3.rdf.xml for testing
mcritchlow
force-pushed
the
feature/more-role-order
branch
from
4d6a11c
to
93c1149
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #634
Local Checklist
masterbranch?What does this PR do?
in the future
testing
Why are we doing this? Any context of related work?
References #634 - RDCP would like more control over name/role ordering, so hopefully the refactoring work in this ticket of the specified role order to a YAML file will help make any future changes a bit more manageable.
@ucsdlib/developers - please review