Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is not it should be for="facebook_link" ? #21

Closed
MrDataPsycho opened this issue Jan 19, 2020 · 5 comments
Closed

Is not it should be for="facebook_link" ? #21

MrDataPsycho opened this issue Jan 19, 2020 · 5 comments

Comments

@MrDataPsycho
Copy link

I think there is a typo in that form tag? Can anyone confirm or I am mistaken?

FSND/projects/01_fyyur/starter_code/templates/forms/new_venue.html

Line 36 in ee22b4e

<label for="genres">Facebook Link</label>

@InfinityByTen
Copy link

There is the same mistake in the other forms as well.

@aditilamkhede
Copy link

Also, id = id.state for facebook and genres element, it should be id.facebook_link and id.genres respectively. It is their in all the forms.

@MattiooFR
Copy link

Well, apparently the "for" attribute exist in the label tag:

https://www.w3schools.com/tags/att_label_for.asp

@robinlamb
Copy link
Contributor

I corrected this in my pull request. #117

@SudKul
Copy link
Contributor

SudKul commented Mar 16, 2021

Fixed in the #117

@SudKul SudKul closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@InfinityByTen @MrDataPsycho @MattiooFR @aditilamkhede @SudKul @robinlamb