Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Quality of Life improvements for Project 01 fyyur #17

Closed
wants to merge 2 commits into from
Closed

Small Quality of Life improvements for Project 01 fyyur #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faa0c81
remove all TODOs from 01_fyyur/forms.py since they are really confusi…
Dec 16, 2019
98c50f9
fix critical and non critical typos in fyyur starter code app.py"
Dec 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions projects/01_fyyur/starter_code/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def venues():
@app.route('/venues/search', methods=['POST'])
def search_venues():
# TODO: implement search on artists with partial string search. Ensure it is case-insensitive.
# seach for Hop should return "The Musical Hop".
# search for Hop should return "The Musical Hop".
# search for "Music" should return "The Musical Hop" and "Park Square Live Music & Coffee"
response={
"count": 1,
Expand Down Expand Up @@ -258,7 +258,7 @@ def artists():
@app.route('/artists/search', methods=['POST'])
def search_artists():
# TODO: implement search on artists with partial string search. Ensure it is case-insensitive.
# seach for "A" should return "Guns N Petals", "Matt Quevado", and "The Wild Sax Band".
# search for "A" should return "Guns N Petals", "Matt Quevado", and "The Wild Sax Band".
# search for "band" should return "The Wild Sax Band".
response={
"count": 1,
Expand All @@ -272,8 +272,8 @@ def search_artists():

@app.route('/artists/<int:artist_id>')
def show_artist(artist_id):
# shows the venue page with the given venue_id
# TODO: replace with real venue data from the venues table, using venue_id
# shows the artist page with the given artist_id
# TODO: replace with real artist data from the artist table, using artist_id
data1={
"id": 4,
"name": "Guns N Petals",
Expand Down
6 changes: 0 additions & 6 deletions projects/01_fyyur/starter_code/forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ class VenueForm(Form):
'image_link'
)
genres = SelectMultipleField(
# TODO implement enum restriction
'genres', validators=[DataRequired()],
choices=[
('Alternative', 'Alternative'),
Expand Down Expand Up @@ -181,14 +180,12 @@ class ArtistForm(Form):
]
)
phone = StringField(
# TODO implement validation logic for state
'phone'
)
image_link = StringField(
'image_link'
)
genres = SelectMultipleField(
# TODO implement enum restriction
'genres', validators=[DataRequired()],
choices=[
('Alternative', 'Alternative'),
Expand All @@ -213,8 +210,5 @@ class ArtistForm(Form):
]
)
facebook_link = StringField(
# TODO implement enum restriction
'facebook_link', validators=[URL()]
)

# TODO IMPLEMENT NEW ARTIST FORM AND NEW SHOW FORM