Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Page as per course ( Lesson 1 Section 10 : Add your project ) is not coming up. #4

Open
bhupendra1011 opened this issue Nov 15, 2017 · 10 comments

Comments

@bhupendra1011
Copy link

bhupendra1011 commented Nov 15, 2017

Hi ,
I am learning Udacity course : https://in.udacity.com/course/intro-to-progressive-web-apps--ud811.
In lession 1 , I cloned this repo & when I started code folder { 1- 12- skeleton } from chrome web server . I am not able to view same page as shown in course , blank page with spinner. Instead I get Add your CIty .

screen shot 2017-11-15 at 1 55 07 pm

Kindly let me know how to get loading spinner page.

@silviolucenajunior
Copy link

You need update you index.html file to insert stylesheet and script. Has comments on index.html page about location in code to add this.

@bhupendra1011
Copy link
Author

@silviolucenajunior what is the location of index.html that I need to use . I guess it's missing in the repo

@swarupbam
Copy link

swarupbam commented Nov 21, 2017

Just add the path of CSS file.
styles/ud811.css

@pengas
Copy link

pengas commented Nov 27, 2017

Just curious why not link to the available stylesheet within the project?

@sunladyjoy
Copy link

sunladyjoy commented Nov 30, 2017

Added the links to the css & js files yet Chrome's Web Server just keeps spinning & never loading.

ah, gesh https://developers.google.com/web/fundamentals/codelabs/your-first-pwapp/
it's supposed to be doing that... and apparently only that at this point! hehehe

@kaquinones
Copy link

kaquinones commented Feb 7, 2018

Modify the index.html
line 9: (Insert link to stylesheet here)
with this: (link rel="stylesheet" type="text/css" href="/1-12-skeleton/styles/ud811.css")
Need to do the same thing for app.js line 145 on index.html and images on the css file, for instance:
css file line 96: background: url(/images/ic_refresh_white_24px.svg) center center no-repeat; } you need add /1-12-skeleton before /images/ic_refresh_white_24px.svg
everything should be fine after those changes

image

@axixnix
Copy link

axixnix commented Jul 12, 2018

screenshot 177
screenshot 178
screenshot 179

can anyone help me here? I have done the css and js linking but nothing has change the project is still as it was initially.

@axixnix
Copy link

axixnix commented Jul 12, 2018

screenshot 180
this is what it looks like in my browser

@shawnoberrath
Copy link

axixnix, in line 10, you need to delete the slash in front of "styles," so "styles/ud811.css"

@apreshagarwal
Copy link

apreshagarwal commented Jan 25, 2019

Solution to issue #4

  • Step 1: Replace the <!-- Insert link to stylesheet here --> on line 9 in ud811-master/1-12-skeleton/index.html with <link rel="stylesheet" type="text/css" href="styles/ud811.css">

  • Step 2: Replace the <!-- Insert link to app.js here --> on line 145 in ud811-master/1-12-skeleton/index.html with <script type="text/javascript" src="scripts/app.js"></script>

  • Step 3: Replace the background: url(/images/ic_refresh_white_24px.svg) center center no-repeat; on line 96 in ud811-master/1-12-skeleton/styles/ud811.css with background: url(../images/ic_refresh_white_24px.svg) center center no-repeat;

  • Step 3: Replace the background: url(/images/ic_add_white_24px.svg) center center no-repeat; on line 98 in ud811-master/1-12-skeleton/styles/ud811.css with background: url(../images/ic_add_white_24px.svg) center center #no-repeat;

  • Step 4: Clean your browser cache and close the browser. Now open your browser again and then open the index.html in a new tab to see the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants