Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryParams being assigned to incorrect routes #36

Closed
mrum-cuscal opened this issue Jul 8, 2020 · 4 comments
Closed

QueryParams being assigned to incorrect routes #36

mrum-cuscal opened this issue Jul 8, 2020 · 4 comments
Assignees

Comments

@mrum-cuscal
Copy link

Describe the bug
I have some routes which have query params. e.g.
route1: statements (no query params)
route2: statement/:statementId?key=value
route3: statement/:statementId/:otherroute?key=value&key2=value2

When I navigate to route3 I am finding that my route1 and route2 are getting assinged the query params from route3

I think the issue is in the resolveQueryParam method. It seems to be assigning the queryParams to the all the routes (not just the route that requires them)

@udayvunnam
Copy link
Owner

@mrum-cuscal Thanks for reporting this bug. A PR fix is always welcome. If not, I will try fixing this weekend.

@jeejeeu
Copy link

jeejeeu commented Jul 8, 2020

Thanks, logged in with a work account previously. I have isolated the issue to the resolveQueryParam method but cannot quite understand how to fix it correctly. Any help would be greatly appreciated.

@udayvunnam udayvunnam self-assigned this Jul 9, 2020
udayvunnam added a commit that referenced this issue Jul 19, 2020
@udayvunnam
Copy link
Owner

@mrum-cuscal @jeejeeu This issue has been fixed with latest release xng-breadcrumb@6.0.0

@jeejeeu
Copy link

jeejeeu commented Jul 21, 2020

Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants