Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use react-tweet for Tweets #2537

Merged
merged 8 commits into from
Jul 26, 2023
Merged

Use react-tweet for Tweets #2537

merged 8 commits into from
Jul 26, 2023

Conversation

haydencarlson
Copy link
Contributor

@haydencarlson haydencarlson commented Jul 26, 2023

Description

See changesets.

Implements react-tweet to reduce amount of client side JS required.
This is very helpful for us in reducing the amount of JS needed to load when displaying tweets 👍

https://vercel.com/blog/introducing-react-tweet

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023

🦋 Changeset detected

Latest commit: c3c0010

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-media Major
@udecode/plate Major
@udecode/plate-serializer-docx Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2023 2:46pm

@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 26, 2023

AI-Generated Summary: This pull request adds the library 'react-tweet' to handle tweets in the project, replacing a substantial amount of the custom code previously used. This overall simplifies the Tweet component, using react-tweet for all functionalities instead of the previous approach that used widget scripts from twitter. Also, the code adjustments resulted in an update to the 'yarn.lock' file to include the new dependencies brought by the 'react-tweet' library.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jul 26, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Jul 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please rebase your pull request on the latest changes

@zbeyens zbeyens merged commit d359bc9 into udecode:main Jul 26, 2023
5 of 7 checks passed
@zbeyens zbeyens mentioned this pull request Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants