Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox rework #3168

Merged
merged 41 commits into from
Jun 6, 2024
Merged

Combobox rework #3168

merged 41 commits into from
Jun 6, 2024

Commits on May 1, 2024

  1. Commit yarn.lock

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    acb0b91 View commit details
    Browse the repository at this point in the history

  2. Fix: www app uses separate slate-react to packages, breaking useSelected

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    869f868 View commit details
    Browse the repository at this point in the history

  3. Prototype combobox input inside slash-input-element.tsx

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    437738e View commit details
    Browse the repository at this point in the history

  4. Refactor combobox input hooks into package

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    4aaf43c View commit details
    Browse the repository at this point in the history

  5. Refactor createSlashPlugin to use combobox helper

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    71bbfce View commit details
    Browse the repository at this point in the history

  6. Prototype InlineCombobox component

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2f486a2 View commit details
    Browse the repository at this point in the history

  7. Refactor out InlineCombobox component

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    7ed9cdb View commit details
    Browse the repository at this point in the history

  8. Add tests for matchWords

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1783605 View commit details
    Browse the repository at this point in the history

  9. Fully implement slash commands using new combobox

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f866183 View commit details
    Browse the repository at this point in the history

  10. Fix error when focusing

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    2c98587 View commit details
    Browse the repository at this point in the history

  11. Fix CSS leaking into combobox popover

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    297657e View commit details
    Browse the repository at this point in the history

  12. Fix: Aliases backwards for [un]ordered lists

    @12joan
    12joan committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f9f21b6 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Use cva for combobox item styles

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2890a67 View commit details
    Browse the repository at this point in the history

  2. Refactor aliases -> keywords

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    b6e1dab View commit details
    Browse the repository at this point in the history

  3. Remove SlashPlugin type

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4818f2d View commit details
    Browse the repository at this point in the history

  4. Refactor query -> search

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    42f2421 View commit details
    Browse the repository at this point in the history

  5. Drop label and make value user-facing

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    766ab37 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into feat/combobox

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    878b1ca View commit details
    Browse the repository at this point in the history

  7. Fix: SlashCommandRule doesn't need exporting

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e5034c8 View commit details
    Browse the repository at this point in the history

  8. Refactor withInsertTextTriggerCombobox -> withTriggerCombobox

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    a20be89 View commit details
    Browse the repository at this point in the history

  9. Refactor TriggerComboboxPlugin options

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    f5e0553 View commit details
    Browse the repository at this point in the history

  10. Revert "Fix: www app uses separate slate-react to packages, breaking … 

    …useSelected"

This reverts commit 869f868.
    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    26e92a7 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into feat/combobox

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    88f386c View commit details
    Browse the repository at this point in the history

  12. Rename match -> filter

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7cca80c View commit details
    Browse the repository at this point in the history

  13. Refactor InlineCombobox into multiple components

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    13f4fa9 View commit details
    Browse the repository at this point in the history

  14. Fix: InlineComboboxItem className should be merged

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    2c86fbf View commit details
    Browse the repository at this point in the history

  15. Remove unnecessary ?.

    @12joan
    12joan committed May 2, 2024
    Configuration menu
    Copy the full SHA
    538cc02 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Use new combobox API for mentions

    @12joan
    12joan committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4a5c168 View commit details
    Browse the repository at this point in the history

  2. Remove mention-combobox from registry.ts

    @12joan
    12joan committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d958373 View commit details
    Browse the repository at this point in the history

  3. yarn build:registry

    @12joan
    12joan committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2aa6b5b View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Merge branch 'refs/heads/main' into feat/combobox 

    # Conflicts:
#	apps/www/public/registry/index.json
#	apps/www/public/registry/styles/default/mention-input-element.json
#	apps/www/src/lib/plate/demo/values/mentionables.ts
#	apps/www/src/lib/plate/demo/values/slashRules.ts
#	apps/www/src/registry/default/example/playground-demo.tsx
#	apps/www/src/registry/default/plate-ui/mention-combobox.tsx
#	apps/www/src/registry/default/plate-ui/mention-input-element.tsx
#	apps/www/src/registry/default/plate-ui/slash-combobox.tsx
#	apps/www/src/registry/default/plate-ui/slash-input-element.tsx
#	apps/www/src/registry/registry.ts
#	packages/mention/src/__tests__/createEditorWithMentions.tsx
#	packages/mention/src/createMentionPlugin.ts
#	packages/mention/src/getMentionOnSelectItem.ts
#	packages/mention/src/handlers/index.ts
#	packages/mention/src/handlers/mentionOnKeyDownHandler.spec.tsx
#	packages/mention/src/handlers/mentionOnKeyDownHandler.ts
#	packages/mention/src/queries/findMentionInput.ts
#	packages/mention/src/queries/index.ts
#	packages/mention/src/queries/isNodeMentionInput.ts
#	packages/mention/src/queries/isSelectionInMentionInput.ts
#	packages/mention/src/transforms/index.ts
#	packages/mention/src/transforms/removeMentionInput.ts
#	packages/mention/src/types.ts
#	packages/mention/src/withMention.spec.tsx
#	packages/mention/src/withMention.ts
#	packages/slash-command/src/createSlashPlugin.ts
#	packages/slash-command/src/getSlashOnSelectItem.ts
#	packages/slash-command/src/handlers/index.ts
#	packages/slash-command/src/handlers/slashOnKeyDownHandler.ts
#	packages/slash-command/src/queries/findSlashInput.ts
#	packages/slash-command/src/queries/index.ts
#	packages/slash-command/src/queries/isNodeSlashInput.ts
#	packages/slash-command/src/queries/isSelectionInSlashInput.ts
#	packages/slash-command/src/transforms/index.ts
#	packages/slash-command/src/transforms/removeSlashInput.ts
#	packages/slash-command/src/types.ts
#	packages/slash-command/src/withSlashCommand.ts
#	packages/slate/src/interfaces/element/TElement.ts
#	packages/slate/src/interfaces/node/TAncestor.ts
    zbeyens committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f74f4f8 View commit details
    Browse the repository at this point in the history

  2. eslint

    zbeyens committed May 6, 2024
    Configuration menu
    Copy the full SHA
    d32625b View commit details
    Browse the repository at this point in the history

  3. eslint

    zbeyens committed May 6, 2024
    Configuration menu
    Copy the full SHA
    751a9bb View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Use combobox with emoji picker

    @12joan
    12joan committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8cf1b3d View commit details
    Browse the repository at this point in the history

  2. Delete old combobox code

    @12joan
    12joan committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    27616fe View commit details
    Browse the repository at this point in the history

  3. Remove old combobox component

    @12joan
    12joan committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    af87f80 View commit details
    Browse the repository at this point in the history

  4. Fix: Trigger is inserted in the wrong place on selection change

    @12joan
    12joan committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    035752f View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Update registry and docs

    @12joan
    12joan committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9288232 View commit details
    Browse the repository at this point in the history

  2. Linter and brl fixes

    @12joan
    12joan committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    5424940 View commit details
    Browse the repository at this point in the history

  3. Add package changesets

    @12joan
    12joan committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6985cf6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into feat/combobox

    @12joan
    12joan committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4dac4cb View commit details
    Browse the repository at this point in the history