Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change zIndex of floating link #3204

Merged
merged 7 commits into from
May 19, 2024

Conversation

jijiseong
Copy link
Contributor

@jijiseong jijiseong commented May 19, 2024

Description

close #3144

I fixed the zIndex of useFloatingLinkInsert according to 12joan's comment, but the same problem still exists.
So I resolved this issue by fixing the zIndex of useFloatingLinkEdit.

It works without any problems.
But I'm not sure if changing the zIndex to 30 is the best way.

2024-05-19.10.18.05.mov

Copy link

changeset-bot bot commented May 19, 2024

🦋 Changeset detected

Latest commit: 136fb3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@udecode/plate-link Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2024 3:17am

@felixfeng33
Copy link
Collaborator

felixfeng33 commented May 19, 2024

Thanks.Could you fix this while you're at it?

I fixed the zIndex of useFloatingLinkInsert according to 12joan's comment, but the same problem still exists.

change the zIndex not work for this case?

link.mp4

@jijiseong

@jijiseong
Copy link
Contributor Author

The table seperator's z-index is 40.
Would it be okay if I change the floating link's z-index to 50?

@jijiseong
Copy link
Contributor Author

2024-05-19.11.03.38.mov

It works fine 😀

@felixfeng33
Copy link
Collaborator

felixfeng33 commented May 19, 2024

Thank you I think it's ok.Could you add a changeset?
Change the files below packages/* will release the package.

@felixfeng33
Copy link
Collaborator

These two input may need to be adjusted as well.

image

@jijiseong
Copy link
Contributor Author

jijiseong commented May 19, 2024

should I delete .changeset/plenty-suits-serve.md ?

@felixfeng33
Copy link
Collaborator

should I delete .changeset/plenty-suits-serve.md ?

yeah. I have removed and change to patch.

@felixfeng33 felixfeng33 merged commit ad036f3 into udecode:main May 19, 2024
6 checks passed
@jijiseong jijiseong changed the title fix: zIndex of floating link fix: Change zIndex of floating link May 19, 2024
@jijiseong jijiseong deleted the fix/floating-link-zIndex branch May 19, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to use link form a table
2 participants