New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent request-racing in futures wrapper #2

Open

udoprog opened this issue Jul 19, 2019 · 0 comments

Labels

Owner

udoprog commented Jul 19, 2019 •

edited

Loading

Currently any asynchronous request that enters wrap will race against each other, causing more requests than needed to go through.

Instead, do:

Only one request for a given unique key may be pending at a time, the other futures should queue up.
If that one request fails, all queued up futures should be marked as failed with the same error (this might be an issue if the error is not Clone). Alternatively, we provide our own error variant for this case.

The text was updated successfully, but these errors were encountered:

udoprog added the enhancement label

udoprog added a commit that referenced this issue


          First stab at fixing #2

e9868d3

udoprog added a commit that referenced this issue


          First stab at fixing #2

e89d58d

udoprog added a commit that referenced this issue


          First stab at fixing #2

bf586fc

udoprog added a commit that referenced this issue


          First stab at fixing #2

c05233e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment